-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add xtask support for refresh slide list. #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54dd4f8
to
6c60578
Compare
I'm sorry for the huge delay. I already prepared my review but somehow did not click the submit button... |
Hi @michael-kerscher . I noticed a difference in behavior when passing a directory using the full path (e.g. When using the full path, the slide list gets recreated but it seems like the actual testing of the slide dimensions doesn't happen. When using the shorter path from the workspace directory, it seems to work as expected. Is there a difference in how these paths are treated from within the web tests? |
Hmm, if that is an issue for the actual test runner, this would be some interaction with npm or something inside wdio. I need to look at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolute paths are fine, relative paths have conflicting usage, once with the CARGO_WORKSPACE_DIR/ and once with CARGO_WORKSPACE_DIR/tests/ (due to different working directories being used). You can resolve this issue by just converting the relative path to an absolute path. This also checks the directory and can provide early errors if the directory is wrong or does not exist
e10404d
to
33bf191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me now!
Adds support for a
refresh-slide-list
argument when running the commandcargo xtask web-tests
. Allows one to also specify an optional book html directory if one uses therefresh-slide-list
argument. Fixes #2744 .