Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Automodel Queries #18022

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Delete Automodel Queries #18022

merged 2 commits into from
Nov 22, 2024

Conversation

kaeluka
Copy link
Contributor

@kaeluka kaeluka commented Nov 19, 2024

Note

Dear reviewer:

  • I would be surprised if anyone other than us would use these queries, but they were public and that means dropping them should get a change note.
  • To do that, this PR only removes the queries and qlpack files, but it leaves the change log directory in place so that I can write a change note about this packages' removal. Are you aware of any automation or expectations this might break?
  • I think we should remove the change log directory as well after the next release was done and the change log message has been distributed to users, right? Or should the directory stay there?

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@kaeluka kaeluka force-pushed the kaeluka/4648-remove-automodel-queries branch from 0e4f045 to 4208f03 Compare November 19, 2024 09:40
@kaeluka kaeluka marked this pull request as ready for review November 19, 2024 10:42
@kaeluka kaeluka requested a review from a team as a code owner November 19, 2024 10:42
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

These queries were last published in August 2023. https://github.com/orgs/codeql/packages?tab=packages&q=java-automodel-queries

If anyone is relying on these queries, then they can use the published variants of them. Since we are not including these queries in the bundle, I'd be extremely surprised if someone is using them from this repo.

@kaeluka
Copy link
Contributor Author

kaeluka commented Nov 20, 2024

Thank you, Andrew! I'm leaving this open until tomorrow ~lunch time in case the @github/codeql-java team has comments as well. Then I'll merge 👍

@kaeluka kaeluka merged commit 30581d7 into main Nov 22, 2024
12 checks passed
@kaeluka kaeluka deleted the kaeluka/4648-remove-automodel-queries branch November 22, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants