Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WORKSPACE.bzlmod to Starlark #7121

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

petemounce
Copy link
Contributor

Bazel's bzlmod dependency manager involves Starlark files with .bzlmod file extensions.

https://bazel.build/external/migration#workspace.bzlmod

Description

Checklist:

Bazel's bzlmod dependency manager involves Starlark files with `.bzlmod` file extensions.

https://bazel.build/external/migration#workspace.bzlmod
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample needs to be added to this PR.

The docs you referenced also only mentions WORKSPACE.bzlmod and excluding this file from search returns only 7 files, six of which are owned by the same repo so I think it's probably better to add this as a new named file for now and not as a new extension.

@petemounce
Copy link
Contributor Author

@lildude many thanks for the fast turnaround.

I haven't understood what to do about the sample license(s) part; how to proceed there?

I've adjusted to only aim for WORKSPACE.bzlmod.

@lildude
Copy link
Member

lildude commented Nov 25, 2024

I've adjusted to only aim for WORKSPACE.bzlmod.

Thanks. We still need a sample.

@lildude lildude changed the title Make .bzlmod handled by Starlark Add WORKSPACE.bzlmod to Starlark Nov 25, 2024
@petemounce
Copy link
Contributor Author

@lildude is something like ln 9650c7c what you have in mind?

@lildude lildude added this pull request to the merge queue Nov 26, 2024
Merged via the queue into github-linguist:main with commit 24796bc Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants