Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MoonBit #7097

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Add MoonBit #7097

merged 7 commits into from
Nov 25, 2024

Conversation

tonyfettes
Copy link
Contributor

This pull request adds support to MoonBit programming language.

Description

This pull request adds support to MoonBit programming language. Here are some relevant resources:

Checklist:

@tonyfettes tonyfettes requested a review from a team as a code owner October 18, 2024 10:33
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

As an aside, there's no need to keep updating the grammar as we pull in the latest version whenever we make a new release.

@hustcer
Copy link
Contributor

hustcer commented Nov 10, 2024

@tonyfettes Should .mbti extension be added also?

@lildude
Copy link
Member

lildude commented Nov 10, 2024

@tonyfettes Should .mbti extension be added also?

I've advise against it as usage is not sufficient for inclusion right now so adding it to this PR will delay this from being merged. Users can use an override as soon as this lands until usage meets requirements.

@tonyfettes
Copy link
Contributor Author

@tonyfettes Should .mbti extension be added also?

@hustcer We are not planning to add .mbti extension in this PR. This file is produced by the moon info command to boost code-preview process, and is currently unstable.

@lildude lildude added this pull request to the merge queue Nov 25, 2024
Merged via the queue into github-linguist:main with commit 065a205 Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants