-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 1C Enterprise grammar #7096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how you did it, but we only need the cached license from the new grammar. Please remove the others.
@lildude yeah, they came from submodule init. let me change it. |
4580bf1
to
bf52a44
Compare
@lildude done |
Kindly ping @lildude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
As an aside, there's really no need for the repeated pings. Why? 👇
Note: this PR will not be merged until close to when the next release is made. See here for more details.
Hello, @lildude! I just migrated grammar files in vsc-language-1c-bsl repo from tmLanguage (plist) to tmLanguage.json I've checked other grammars in this repo and looks like linguist natively supports grammars in json, but I want to double check that everything will work during the linguist release. How could I test, if new format of grammar works correctly? Thanks in advance. |
Replace the grammar with itself like you did when replacing the old grammar with the new. |
37bbac7
to
19e1a59
Compare
Thanks, Colin.
This key is required to some other syntax highlighters (as shiki). Also I checked that new grammar file works in VSCode without errors. I rebased and pushed latest changes (with new sha for submodule, just in case). |
e5275e4
to
3f13173
Compare
3f13173
to
2a223e2
Compare
Replace source repo for bsl (1C Enterprise) language
Description
Since atom was sunset and atom plugin is not maintained anymore, let's get grammar from vscode plugin.
Checklist: