Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OMNeT++ NED language #7024

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Add OMNeT++ NED language #7024

merged 5 commits into from
Nov 25, 2024

Conversation

adamgeorge309
Copy link
Contributor

This adds the OMNeT++ NED language.

Description

NED (extension .ned) is a DSL for the OMNeT++ network simulator. It is used by model frameworks for OMNeT++, such as the INET framework, Simu5G, Veins, etc. We are the team that develops OMNeT++ and the INET Framework and we have created a TextMate grammar for this language.

Checklist:

@adamgeorge309 adamgeorge309 requested a review from a team as a code owner August 31, 2024 08:59
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing the cached licence file from the grammar which should have been created when you ran script/add-grammar:

bundle exec licensed cache -c vendor/licenses/config.yml

Please add this file.

@lildude
Copy link
Member

lildude commented Sep 27, 2024

Please merge main into your branch again as I can't approve CI to run without the latest changes.

@adamgeorge309
Copy link
Contributor Author

adamgeorge309 commented Sep 27, 2024

Merged. Thank you!

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Nov 25, 2024
Merged via the queue into github-linguist:main with commit 9393583 Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants