Skip to content

fix(aci): Ensure slow conditions are consistent #93895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

fix(aci): Ensure slow conditions are consistent #93895

merged 1 commit into from
Jun 20, 2025

Conversation

kcons
Copy link
Member

@kcons kcons commented Jun 19, 2025

The conditions associated with a DCG can change over time, and it's good if we can be completely confident that they're consistent within a given task execution.

@kcons kcons requested a review from a team as a code owner June 19, 2025 00:17
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 19, 2025
Copy link

sentry-io bot commented Jun 19, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/workflow_engine/processors/delayed_workflow.py

Function Unhandled Issue
process_delayed_workflows SoftTimeLimitExceeded: SoftTimeLimitExceeded('SoftTimeLimitExceeded()\nSQL: SELECT "workflow_engine_workflow"."id", "workflow_engine_workflow"."date_updated", "workflow_engine_workflow"."date_added", "workflow_engine_workflow"."config", "workflow_engine_workflow"."owner_user_... ...
Event Count: 6
process_delayed_workflows KeyError: 6676954553 sentry.workflow_engine.proce...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...try/workflow_engine/processors/delayed_workflow.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93895       +/-   ##
===========================================
+ Coverage   37.99%   87.94%   +49.94%     
===========================================
  Files        9771    10311      +540     
  Lines      552180   595690    +43510     
  Branches    23204    23204               
===========================================
+ Hits       209798   523869   +314071     
+ Misses     341918    71357   -270561     
  Partials      464      464               

@kcons kcons merged commit 084b63a into master Jun 20, 2025
64 checks passed
@kcons kcons deleted the kcons/whatif branch June 20, 2025 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants