fix: Invalid context on GraphQL request errors #4567
Draft
+109
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes SentryNetworkTracker to add an object for GraphQL context instead of a string.
💡 Motivation and Context
Fixes #4560.
💚 How did you test it?
graphql
key that looks the way we expect it to look.graphql
context section does.📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps
Ideally I'd like to include the GraphQL operation name in the client tags. This would help us identify which actual calls are causing the most errors — currently we have one issue with tens of thousands of events in it and no good way to figure out which calls are the problem.
But for now I'm just making sure we're able to see the operation correctly on network errors.