test(user-feedback): ui tests to display form, submit, cancel #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feedback)/ui-tests
| } | ||
|
|
||
| func testSubmitFullyFilledForm() throws { | ||
| let widgetButton: XCUIElement = app.staticTexts["Report a Bug"] |
There was a problem hiding this comment.
m: Is there any reason we can't use accessibility identifiers to find the button? These usually don't change that often, and they also work when you add localization, so it makes the test less brittle.
Comment on lines
+47
to
+56
| func testSubmitWithNoFieldsFilled() throws { | ||
| throw XCTSkip("Needs error state implementation") | ||
|
|
||
| let widgetButton: XCUIElement = app.staticTexts["Report a Bug"] | ||
| widgetButton.tap() | ||
|
|
||
| app.staticTexts["Send Bug Report"].tap() | ||
|
|
||
| // TODO: need to implement some kind of error dialog and then assert for it | ||
| } |
There was a problem hiding this comment.
l: I would prefer not to have tests that don't run if possible. They are easily overlooked, start to rot and are never updated again.
There was a problem hiding this comment.
It's implemented in #4544
|
|
||
| app.staticTexts["Send Bug Report"].tap() | ||
|
|
||
| // TODO: need to implement some kind of error dialog and then assert for it |
There was a problem hiding this comment.
m: What's stopping you from doing that in this PR?
There was a problem hiding this comment.
can't do it until validation and error states are implemented in #4544
…feedback)/ui-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[for https://github.com//issues/4271; #skip-changelog
This helps validate the functionality of the widget button and form. Looking into how I can also validate the contents of the data as they are captured into an envelope, but this at least is a start on ensuring basic UI correctness.
A couple tests are skipped and will be finished in #4544 that deal with error states after failing input validation