-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(user-feedback): capture envelopes #4535
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/feat(user-feedback)/form #4535 +/- ##
=========================================================================
- Coverage 90.927% 90.761% -0.167%
=========================================================================
Files 617 618 +1
Lines 70421 69372 -1049
Branches 25161 24828 -333
=========================================================================
- Hits 64032 62963 -1069
- Misses 6296 6316 +20
Partials 93 93
... and 68 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fb731a3 | 1228.04 ms | 1256.69 ms | 28.65 ms |
8060f3f | 1229.92 ms | 1248.67 ms | 18.75 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fb731a3 | 22.30 KiB | 745.19 KiB | 722.89 KiB |
8060f3f | 22.30 KiB | 747.19 KiB | 724.88 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a draft, but I already gave you early feedback.
for #4272; #skip-changelog
capture the user feedback in an envelope. currently, an error is required to have been captured, with its event ID supplied in the user feedback object. so, a dummy error is currently created to satisfy this requirement to be able to see them in the dashboard (see linked issue for progress/results)
TODOs