Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(user-feedback): capture envelopes #4535

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Nov 15, 2024

for #4272; #skip-changelog

capture the user feedback in an envelope. currently, an error is required to have been captured, with its event ID supplied in the user feedback object. so, a dummy error is currently created to satisfy this requirement to be able to see them in the dashboard (see linked issue for progress/results)

TODOs

Copy link

github-actions bot commented Nov 15, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against eea1f96

@armcknight armcknight marked this pull request as ready for review November 15, 2024 00:51
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.761%. Comparing base (f24bd66) to head (210286d).

Files with missing lines Patch % Lines
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% 12 Missing ⚠️
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                            @@
##           armcknight/feat(user-feedback)/form     #4535       +/-   ##
=========================================================================
- Coverage                               90.927%   90.761%   -0.167%     
=========================================================================
  Files                                      617       618        +1     
  Lines                                    70421     69372     -1049     
  Branches                                 25161     24828      -333     
=========================================================================
- Hits                                     64032     62963     -1069     
- Misses                                    6296      6316       +20     
  Partials                                    93        93               
Files with missing lines Coverage Δ
...Feedback/SentryUserFeedbackIntegrationDriver.swift 0.000% <ø> (ø)
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% <0.000%> (ø)
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% <0.000%> (ø)

... and 68 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24bd66...210286d. Read the comment docs.

Copy link

github-actions bot commented Nov 15, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.08 ms 1256.96 ms 19.88 ms
Size 21.90 KiB 746.34 KiB 724.43 KiB

Baseline results on branch: armcknight/feat(user-feedback)/form

Startup times

Revision Plain With Sentry Diff
fb731a3 1228.04 ms 1256.69 ms 28.65 ms
8060f3f 1229.92 ms 1248.67 ms 18.75 ms

App size

Revision Plain With Sentry Diff
fb731a3 22.30 KiB 745.19 KiB 722.89 KiB
8060f3f 22.30 KiB 747.19 KiB 724.88 KiB

Previous results on branch: armcknight/feat(user-feedback)/envelope

Startup times

Revision Plain With Sentry Diff
86abdac 1209.79 ms 1233.82 ms 24.02 ms

App size

Revision Plain With Sentry Diff
86abdac 21.90 KiB 744.30 KiB 722.40 KiB

@armcknight armcknight linked an issue Nov 15, 2024 that may be closed by this pull request
@armcknight armcknight marked this pull request as draft November 15, 2024 02:19
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a draft, but I already gave you early feedback.

Base automatically changed from armcknight/feat(user-feedback)/form to main November 19, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Feedback envelope (Due: Dec 13)
3 participants