Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Building SDK from source with Xcode 15.3 #4483

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix: Building SDK from source with Xcode 15.3 #4483

wants to merge 9 commits into from

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 29, 2024 •
edited
Loading

📜 Description

Recreate SwiftUITestSample.xcodeproj with Xcode 15.1 so users can compile the SDK from source on Xcode 15.0 and above.

💡 Motivation and Context

Fixes GH-4476

💚 How did you test it?

Manually with Xcode 15.1.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@philipphofmann
fix: Building SDK from source with Xcode 15.3
2dcbdec 
Set compatibilityVersion for SwiftUITestSample.xcodeproj to 14.0
instead of 15.3 so users can compile the SDK from source on Xcode 14.0
and above.

Fixes GH-4476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armcknight armcknight Awaiting requested review from armcknight armcknight is a code owner

@brustolin brustolin Awaiting requested review from brustolin brustolin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not build release 8.39.0 with Xcode 15.1
2 participants
@philipphofmann @brustolin