-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
es-toolkit scraper #2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
es-toolkit scraper #2517
+99
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Thank you so much for this wonderfully thing!! I will be gonna prepare at
morning
…On Tue, 3 Jun 2025 at 4:26 AM, Adam Doppelt ***@***.***> wrote:
Hi guys, I love devdocs! I've been using es-toolkit instead of lodash
recently and I decided to write a scraper. The es-toolkit scraper is
similar to date-fns. It uses a clone of the es-toolkit repo to process
the markdown, with some regular expressions to clean things up. What do you
think?
Thanks for making such a great project.
- Tested the scraper on a local copy of DevDocs
- Ensured that the docs are styled similarly to other docs on DevDocs
- Added these files to the public/icons/*your_scraper_name*/
directory:
- 16.png: a 16×16 pixel icon for the doc
- ***@***.***: a 32×32 pixel icon for the doc
- SOURCE: A text file containing the URL to the page the image can
be found on or the URL of the original image itself
------------------------------
You can view, comment on, or merge this pull request online at:
#2517
Commit Summary
- 93c3c57
<93c3c57>
es-toolkit scraper
File Changes
(5 files <https://github.com/freeCodeCamp/devdocs/pull/2517/files>)
- *M* docs/file-scrapers.md
<https://github.com/freeCodeCamp/devdocs/pull/2517/files#diff-10d463e53b49e70479381c1c5c121da2feb3375d5724c5f5ebd3fb92d6b07e89>
(6)
- *A* lib/docs/scrapers/es_toolkit.rb
<https://github.com/freeCodeCamp/devdocs/pull/2517/files#diff-51eac55d7c1d208a0bfbbcd558045792f885a743473c5a96000be1b95b51cbb2>
(87)
- *A* public/icons/docs/es_toolkit/16.png
<https://github.com/freeCodeCamp/devdocs/pull/2517/files#diff-bd7d56f7a13ac8cd0e42379f8b364f6fc7da83415a6c5a65819361d7b42c2b4f>
(0)
- *A* ***@***.***
<https://github.com/freeCodeCamp/devdocs/pull/2517/files#diff-9ac35c96321eeb57ff52f9dd3335c1fcbed0a92b2b7a0b2e512b3160c471da67>
(0)
- *A* public/icons/docs/es_toolkit/SOURCE
<https://github.com/freeCodeCamp/devdocs/pull/2517/files#diff-c9870a675db7805340b0f3a2ba1c4bf3a2149014400a3c66905f50172101ca01>
(1)
Patch Links:
- https://github.com/freeCodeCamp/devdocs/pull/2517.patch
- https://github.com/freeCodeCamp/devdocs/pull/2517.diff
—
Reply to this email directly, view it on GitHub
<#2517>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BR7SGIOFIM7RDNF532CSA3D3BTJCPAVCNFSM6AAAAAB6OGAQWGVHI2DSMVQWIX3LMV43ASLTON2WKOZTGEYTCOBWHE4DIMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Loading status checks…
simon04
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
My pleasure, maybe I'll add more! Pretty easy. I can think of some wording improvements to the scraper docs as well. Let me know if you are interested. Thanks Simon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, I love devdocs! I've been using
es-toolkit
instead oflodash
recently and I decided to write a scraper. The es-toolkit scraper is similar todate-fns
. It uses a clone of the es-toolkit repo to process the markdown, with some regular expressions to clean things up. What do you think?Thanks for making such a great project.
public/icons/your_scraper_name/
directory:16.png
: a 16×16 pixel icon for the doc16@2x.png
: a 32×32 pixel icon for the docSOURCE
: A text file containing the URL to the page the image can be found on or the URL of the original image itself