Skip to content

Support experimental extensions in CLI - #2830

Merged
i14h merged 12 commits into
masterfrom
ir-support-experimental-extensions
Jan 7, 2021
Merged

Support experimental extensions in CLI#2830
i14h merged 12 commits into
masterfrom
ir-support-experimental-extensions

Conversation

@i14h

@i14h i14h commented Nov 16, 2020

Copy link
Copy Markdown
Member

Description

Allow the CLI to show a warning message when the user is installing an experimental extension.

Scenarios Tested

npm test

@i14h
i14h requested a review from joehan November 16, 2020 23:53
@google-cla google-cla Bot added the cla: yes Manual indication that this has passed CLA. label Nov 16, 2020
@i14h
i14h requested a review from kevinthecheung November 16, 2020 23:55
@i14h

i14h commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

@kevinthecheung can you check the copy please?

Comment thread src/extensions/resolveSource.ts Outdated
i14h and others added 2 commits November 30, 2020 07:30
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
@i14h

i14h commented Nov 30, 2020

Copy link
Copy Markdown
Member Author

@huangjeff5 Can you also take a look and see if this fits well with the backend?

@huangjeff5

Copy link
Copy Markdown
Contributor

@huangjeff5 Can you also take a look and see if this fits well with the backend?

Looks good to me, although the concept of varying "audiences" only exists on the official extensions currently. We plan to add an "audience" field to extensions stored on the backend in Q1 sometime, so that we can migrate official extensions to use the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants