Skip to content

Conversation

@xen143
Copy link

@xen143 xen143 commented Jun 24, 2025

I have added an option to change the default warning message when the root directory (or one of the root directories) is not found. (#524)

Checklist

@xen143 xen143 changed the title Adding an option to surpress or modify the non-existent root directory warning (#524) Adding an option to modify the non-existent root directory warning (#524) Jun 24, 2025
@xen143
Copy link
Author

xen143 commented Jun 24, 2025

Force-pushes above were for fixing minor issues I have overlooked, such as extra semicolon, etc.

@jean-michelet
Copy link
Member

Hi, thanks for the PR!

Why do you think this is useful?

@xen143
Copy link
Author

xen143 commented Jun 25, 2025

Hi, thanks for the PR!

Why do you think this is useful?

Hi, two reasons occur to me:

  1. Let's say all my log messages start with a capital letter — the default message doesn't. I know this is more of a stylistic concern than a functional one.
  2. Language localization — perhaps I have a server that logs messages in a language other than English. This change would help keep the logging consistent.

@mcollina
Copy link
Member

I'm not really convinved this is worth adding, you can easily wrap this module in another and add whatever option validation you need.

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 21, 2025

Without a real use case I think we have to reject your proposal.

@Uzlopak Uzlopak closed this Aug 21, 2025
@xen143 xen143 deleted the custom-missing-root-warning branch August 23, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants