Skip to content

improve rules validation#3805

Merged
poiana merged 3 commits into
masterfrom
chore/improve-rules-validation
Mar 17, 2026
Merged

improve rules validation#3805
poiana merged 3 commits into
masterfrom
chore/improve-rules-validation

Conversation

@leogr

@leogr leogr commented Feb 17, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1332

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat: validation for unknown-key in rules

@github-actions

Copy link
Copy Markdown

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@leogr

leogr commented Feb 17, 2026

Copy link
Copy Markdown
Member Author

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

False positive
/hold cancel

@leogr leogr changed the title wip: improve rules validation improve rules validation Feb 19, 2026
@leogr

leogr commented Feb 19, 2026

Copy link
Copy Markdown
Member Author

/milestone 0.44.0

@poiana poiana added this to the 0.44.0 milestone Feb 19, 2026
leogr added 3 commits March 12, 2026 12:23
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the chore/improve-rules-validation branch from 9ae76a5 to 0b651a4 Compare March 12, 2026 11:23

@ekoops ekoops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@irozzo-1A irozzo-1A left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation Bot moved this from Todo to In progress in Falco Roadmap Mar 17, 2026
@poiana

poiana commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit bb40486 into master Mar 17, 2026
34 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Falco Roadmap Mar 17, 2026
@poiana poiana deleted the chore/improve-rules-validation branch March 17, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improve rule files validity checking

4 participants