Skip to content

Spherical mercator transformation should handle properly out of bounds latitudes#81145

Merged
iverase merged 3 commits into
elastic:masterfrom
iverase:lat_lower_limit
Dec 1, 2021
Merged

Spherical mercator transformation should handle properly out of bounds latitudes#81145
iverase merged 3 commits into
elastic:masterfrom
iverase:lat_lower_limit

Conversation

@iverase

@iverase iverase commented Nov 30, 2021

Copy link
Copy Markdown
Contributor

Currently for latitudes close to -90, the transformation return -Infinity. This changes make sure we always return a correct number so we prevent issues downstream.

Fixes #81128

@iverase iverase added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.16.1 v8.1.0 labels Nov 30, 2021
@iverase iverase requested a review from imotov November 30, 2021 11:28
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 30, 2021
@elasticmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@imotov imotov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit 3a3bb23 into elastic:master Dec 1, 2021
@iverase iverase deleted the lat_lower_limit branch December 1, 2021 06:04
iverase added a commit to iverase/elasticsearch that referenced this pull request Dec 1, 2021
…s latitudes (elastic#81145)

Handle properly latitudes close to -90.
iverase added a commit to iverase/elasticsearch that referenced this pull request Dec 1, 2021
…s latitudes (elastic#81145)

Handle properly latitudes close to -90.
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
8.0
7.16

elasticsearchmachine pushed a commit that referenced this pull request Dec 1, 2021
…s latitudes (#81145) (#81198)

Handle properly latitudes close to -90.
elasticsearchmachine pushed a commit that referenced this pull request Dec 1, 2021
…s latitudes (#81145) (#81199)

Handle properly latitudes close to -90.
@danhermann danhermann added v7.16.0 and removed v7.16.1 labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.16.0 v8.0.0-rc1 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] GeoShapeWithDocValuesFieldTypeTests testFetchVectorTile failing

6 participants