[ML] ML legacy index templates that are no longer needed should be deleted#80874
Merged
droberts195 merged 2 commits intoNov 19, 2021
Merged
Conversation
…leted We no longer need any ML legacy index templates, as we've switched to either composable index templates or system indices. All the ML legacy templates we've created over the years should be deleted, as they're just confusing clutter within the cluster now.
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
commented
Nov 19, 2021
Comment on lines
+162
to
+165
| // Don't delete the legacy templates until the entire cluster is on a version that supports composable templates | ||
| if (state.nodes().getMinNodeVersion().before(MlIndexTemplateRegistry.COMPOSABLE_TEMPLATE_SWITCH_VERSION)) { | ||
| return true; | ||
| } |
Author
There was a problem hiding this comment.
This bit is the key difference in the 7.16 branch compared to #80876.
benwtrent
approved these changes
Nov 19, 2021
This was referenced Nov 19, 2021
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 6, 2022
In elastic#80874 ML legacy templates were removed by continuously monitoring the cluster state and removing the templates once all nodes were on version 7.14 or higher. For 8.x this is unnecessarily complex. We know the oldest possible node in the cluster will be 7.17, so can just remove all ML legacy templates from the cluster state unconditionally on startup.
droberts195
added a commit
that referenced
this pull request
Jan 6, 2022
In #80874 ML legacy templates were removed by continuously monitoring the cluster state and removing the templates once all nodes were on version 7.14 or higher. For 8.x this is unnecessarily complex. We know the oldest possible node in the cluster will be 7.17, so can just remove all ML legacy templates from the cluster state unconditionally on startup.
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
In elastic#80874 ML legacy templates were removed by continuously monitoring the cluster state and removing the templates once all nodes were on version 7.14 or higher. For 8.x this is unnecessarily complex. We know the oldest possible node in the cluster will be 7.17, so can just remove all ML legacy templates from the cluster state unconditionally on startup.
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
In elastic#80874 ML legacy templates were removed by continuously monitoring the cluster state and removing the templates once all nodes were on version 7.14 or higher. For 8.x this is unnecessarily complex. We know the oldest possible node in the cluster will be 7.17, so can just remove all ML legacy templates from the cluster state unconditionally on startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need any ML legacy index templates, as we've switched to
either composable index templates or system indices. All the ML legacy
templates we've created over the years should be deleted, as they're
just confusing clutter within the cluster now.
This is the 7.16 version of #80876.