Revert 74559 (Avoid global ordinals in composite)#78846
Merged
Conversation
…astic#74754)" This reverts commit ec799ab.
This reverts commit 5cfcb2f. Conflicts: server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/CompositeValuesCollectorQueue.java server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/OrdinalValuesSource.java server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/TermsValuesSourceBuilder.java server/src/test/java/org/elasticsearch/search/aggregations/bucket/composite/SingleDimensionValuesSourceTests.java
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
approved these changes
Oct 7, 2021
nik9000
left a comment
Member
There was a problem hiding this comment.
This looks like the right way to revert and patch the missing value order stuff.
ywelsch
pushed a commit
to ywelsch/elasticsearch
that referenced
this pull request
Nov 8, 2021
This reverts the change to use segment ordinals in composite terms aggregations due to a performance degradation when the field is high cardinality.
ywelsch
added a commit
that referenced
this pull request
Nov 8, 2021
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Nov 8, 2021
…astic#80498) This reverts the change to use segment ordinals in composite terms aggregations due to a performance degradation when the field is high cardinality. Co-authored-by: Mark Tozzi <mark.tozzi@elastic.co>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
…80502) This reverts the change to use segment ordinals in composite terms aggregations due to a performance degradation when the field is high cardinality. Co-authored-by: Mark Tozzi <mark.tozzi@elastic.co> Co-authored-by: Mark Tozzi <mark.tozzi@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #78836
Revert #74559
This reverts the change to use segment ordinals in composite terms aggregations due to a performance degradation when the field is high cardinality.