[ML] add new normalize_above parameter to p_value significant terms heuristic#78833
Merged
benwtrent merged 3 commits intoOct 12, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
103926f to
ef26aa9
Compare
droberts195
approved these changes
Oct 12, 2021
droberts195
left a comment
There was a problem hiding this comment.
LGTM apart from a couple of nits
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 12, 2021
…euristic (elastic#78833) This commit adds the new normalize_above parameter to the p_value significant terms heuristic. This parameter allows for consistent significance results at various scales. When a total count (in or out of the set background set) is above the normalize_above parameter, both the total set and the set including the term are scaled by normalize_above/count where count is term in the set or total set size.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 12, 2021
benwtrent
added a commit
that referenced
this pull request
Oct 12, 2021
benwtrent
added a commit
that referenced
this pull request
Oct 12, 2021
…euristic (#78833) (#78999) This commit adds the new normalize_above parameter to the p_value significant terms heuristic. This parameter allows for consistent significance results at various scales. When a total count (in or out of the set background set) is above the normalize_above parameter, both the total set and the set including the term are scaled by normalize_above/count where count is term in the set or total set size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the new
normalize_aboveparameter to thep_valuesignificantterms heuristic.
This parameter allows for consistent significance results at various scales. When a total count (in or out of the set background set) is above the
normalize_aboveparameter, both the total set and the set including the term are scaled bynormalize_above/countwhere count is term in the set or total set size.