Add cluster state serialization stats#78816
Merged
DaveCTurner merged 5 commits intoOct 15, 2021
Merged
Conversation
This commit adds stats tracking the number and compressed/uncompressed size of cluster states that the master serializes.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
fcofdez
approved these changes
Oct 15, 2021
fcofdez
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a minor nit. 👍
| public static final ClusterStateSerializationStats EMPTY = new ClusterStateSerializationStats(0L, 0L, 0L, 0L, 0L, 0L); | ||
|
|
||
| private final long fullStateCount; | ||
| private final long totalUncompressedFullStateSize; |
Contributor
There was a problem hiding this comment.
nit: can we add the unit as a suffix in these variables?
Member
Author
There was a problem hiding this comment.
I have vivid memories of losing marks in exams over this 🧑🏫 Done in 38422d2.
Member
Author
|
@elasticmachine update branch |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 15, 2021
This commit adds stats tracking the number and compressed/uncompressed size of cluster states that the master serializes. Backport of elastic#78816
DaveCTurner
added a commit
that referenced
this pull request
Oct 15, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 15, 2021
This commit adds stats tracking the number and compressed/uncompressed size of cluster states that the master serializes. Backport of #78816
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds stats tracking the number and compressed/uncompressed
size of cluster states that the master serializes.