Add ability to augment classes with fields from other classes in Painless#76628
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
stu-elastic
approved these changes
Aug 18, 2021
stu-elastic
left a comment
Contributor
There was a problem hiding this comment.
class org.elasticsearch.script.Field {
org.elasticsearch.script.Converter UnsignedLong @augmented[augmented_canonical_class_name="org.elasticsearch.xpack.unsignedlong.UnsignedLongField"]
}
class org.elasticsearch.xpack.unsignedlong.UnsignedLongField @no_import {
}
Works with this change, the bottom class is necessary to avoid a class_not_found_exception
Contributor
Author
|
@stu-elastic Thanks for the review! Will add a Javadoc as requested. |
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Aug 18, 2021
…less (elastic#76628) This change adds a a new "augmented" annotation to the Painless allowlist parser. The first use of the annotation supports adding static final fields to a specified allowlist class from another class. This supports the fields api as we can add additional fields types from other classes and augment the Field class with the new types.
Collaborator
💚 Backport successful
|
jdconrad
added a commit
that referenced
this pull request
Aug 18, 2021
…less (#76628) (#76676) This change adds a a new "augmented" annotation to the Painless allowlist parser. The first use of the annotation supports adding static final fields to a specified allowlist class from another class. This supports the fields api as we can add additional fields types from other classes and augment the Field class with the new types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a a new "augmented" annotation to the Painless allowlist parser. The first use of the annotation supports adding
static finalfields to a specified allowlist class from another class. This supports the fields api as we can add additional fields types from other classes and augment the Field class with the new types.