Add license family attribute to feature usage tracking#76622
Merged
Conversation
The feature usage tracking data currently contains an opaque "name" attribute which identifies the feature that was used. This name needs to be unique enough that certain features can be identified independently of others. For example, distinguishing machine learning jobs from trained models. Yet both those examples are all "machine learning". This commit adds a "family" attribute so that similar tracked features can be grouped together. The output format of the feature usage api is essentially the same; it is still a flat list of features and their last used times. The family attribute can be used on the receiving end to group many features.
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
tvernum
approved these changes
Aug 18, 2021
tvernum
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
I'm still not quite sure how the family is going to be used, but what's in this PR seems reasonable.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 19, 2021
The feature usage tracking data currently contains an opaque "name" attribute which identifies the feature that was used. This name needs to be unique enough that certain features can be identified independently of others. For example, distinguishing machine learning jobs from trained models. Yet both those examples are all "machine learning". This commit adds a "family" attribute so that similar tracked features can be grouped together. The output format of the feature usage api is essentially the same; it is still a flat list of features and their last used times. The family attribute can be used on the receiving end to group many features.
Collaborator
💚 Backport successful
|
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 19, 2021
The feature usage tracking data currently contains an opaque "name" attribute which identifies the feature that was used. This name needs to be unique enough that certain features can be identified independently of others. For example, distinguishing machine learning jobs from trained models. Yet both those examples are all "machine learning". This commit adds a "family" attribute so that similar tracked features can be grouped together. The output format of the feature usage api is essentially the same; it is still a flat list of features and their last used times. The family attribute can be used on the receiving end to group many features.
rjernst
added a commit
that referenced
this pull request
Aug 19, 2021
The feature usage tracking data currently contains an opaque "name" attribute which identifies the feature that was used. This name needs to be unique enough that certain features can be identified independently of others. For example, distinguishing machine learning jobs from trained models. Yet both those examples are all "machine learning". This commit adds a "family" attribute so that similar tracked features can be grouped together. The output format of the feature usage api is essentially the same; it is still a flat list of features and their last used times. The family attribute can be used on the receiving end to group many features.
danhermann
pushed a commit
to danhermann/elasticsearch
that referenced
this pull request
Aug 19, 2021
The feature usage tracking data currently contains an opaque "name" attribute which identifies the feature that was used. This name needs to be unique enough that certain features can be identified independently of others. For example, distinguishing machine learning jobs from trained models. Yet both those examples are all "machine learning". This commit adds a "family" attribute so that similar tracked features can be grouped together. The output format of the feature usage api is essentially the same; it is still a flat list of features and their last used times. The family attribute can be used on the receiving end to group many features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature usage tracking data currently contains an opaque "name"
attribute which identifies the feature that was used. This name needs to
be unique enough that certain features can be identified independently
of others. For example, distinguishing machine learning jobs from
trained models. Yet both those examples are all "machine learning".
This commit adds a "family" attribute so that similar tracked features
can be grouped together. The output format of the feature usage api is
essentially the same; it is still a flat list of features and their last
used times. The family attribute can be used on the receiving end to
group many features.