Disable request cache for non-deterministic runtime fields#75054
Merged
Conversation
This change ensures that a non-deterministic script defined in the runtime mapping is not eligible to the request cache. It also moves the scripts that extract values from source to be considered deterministic. Currently a source-only runtime field defined in a search request is not eligible to the request cache. This commit fixes this discrepancy.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
nik9000
reviewed
Jul 30, 2021
romseygeek
approved these changes
Oct 20, 2021
| * This method fails if {@link #freezeContext()} is called before on this context. | ||
| */ | ||
| public void disableCache() { | ||
| failIfFrozen(); |
Contributor
There was a problem hiding this comment.
It's a bit weird that failIfFrozen disables the cache, given that it sounds like it's just checking state, not mutating it. Maybe we should think about renaming this in a followup?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that a non-deterministic script defined in the runtime mapping is not eligible
to the request cache.
It also moves the scripts that extract values from source to be considered deterministic.
Currently a source-only runtime field defined in a search request is not eligible to the request cache.
This commit fixes this discrepancy.