Skip to content

Split ContextMenu into ContextMenuInner subcomponent #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NyxCode wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Split ContextMenu into ContextMenuInner subcomponent #622

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0478653
remove redundant menuOffsetX
NyxCode May 3, 2021
fd09e96
explicitly declare `level`
NyxCode May 3, 2021
92d1eba
remove explicit store subscription
NyxCode May 3, 2021
3308fd4
extract ContextMenuInner.svelte
NyxCode May 3, 2021
d964704
add ContextMenuInner to index.js and ContextMenu/index.js
NyxCode May 3, 2021
6b95fb6
add JSDocs
NyxCode May 3, 2021
cfc99c5
only preventDefault on root context menu
NyxCode May 3, 2021
6a67f41
add documentation section with example
NyxCode May 3, 2021
ee10776
run `yarn prepack`
NyxCode May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
only preventDefault on root context menu
  • Loading branch information
@NyxCode
NyxCode committed May 3, 2021
commit cfc99c53bf106da2e34aee595ad56ca01fc4d483
3 changes: 2 additions & 1 deletion src/ContextMenu/ContextMenu.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,15 @@

function onContextMenu(e) {
if (level > 1) return;
e.preventDefault();
open = true;
x = e.x;
y = e.y;
}
</script>

<svelte:window
on:contextmenu|preventDefault="{onContextMenu}"
on:contextmenu="{onContextMenu}"
on:click="{(e) => {
if (!open) return;
if (e.target.contains(ref)) close();
Expand Down