fix: remove cyclic dependency between tasks #133
Draft
+52
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the cyclic dependency caused by when copying the generated SO files. This happened because we were doing it as part of
preBuild
task of the AAR library. With a recent change in react-native, where they now wait forpreBuild
task for each subProject to be evaluated first and then run theapp:preBuild
task.We now move our copy task for SO files to
mergeJniLibsTask
which executes after thepreBuild
.Apart from it and not related to cyclic dependency issue, we also move the
app:createBundleReleaseJsAndAssets
topreReleaseBuild
task.Test plan
Tested locally on a project on RN>0.81 and RN<0.81 - 🟢