fix: recreate event buffer in pinpoint if the credentials has changed #14403
+38
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soberm
previously approved these changes
May 23, 2025
soberm
reviewed
May 23, 2025
| @@ -55,4 +55,15 @@ describe('EventBuffer', () => { | |||
| buffer.push(EVENT_OBJECT); | |||
| buffer.push(EVENT_OBJECT); | |||
| }); | |||
|
|
|||
| test('haveCredentialsChanged returns true if credentials has changed', () => { | |||
There was a problem hiding this comment.
have vs hasCredentialsChanged?
osama-rizk
reviewed
May 23, 2025
| @@ -42,6 +42,8 @@ export const getEventBuffer = ({ | |||
| */ | |||
| if (buffer.identityHasChanged(identityId)) { | |||
There was a problem hiding this comment.
Nit: this can be simplified to be
if (buffer.identityHasChanged(identityId) || buffer.haveCredentialsChanged(credentials)) {
buffer.flush();
}
You can also define a variable
const shouldFlushBuffer = buffer.identityHasChanged(identityId) ||
buffer.haveCredentialsChanged(credentials);
if (shouldFlushBuffer) {
buffer.flush();
}
There was a problem hiding this comment.
Had this same thought as a nit. Good either way, but would prefer to simplify to a single branch
stocaaro
previously approved these changes
May 23, 2025
| @@ -42,6 +42,8 @@ export const getEventBuffer = ({ | |||
| */ | |||
| if (buffer.identityHasChanged(identityId)) { | |||
There was a problem hiding this comment.
Had this same thought as a nit. Good either way, but would prefer to simplify to a single branch
| @@ -55,4 +55,15 @@ describe('EventBuffer', () => { | |||
| buffer.push(EVENT_OBJECT); | |||
| buffer.push(EVENT_OBJECT); | |||
| }); | |||
|
|
|||
| test('haveCredentialsChanged returns true if credentials has changed', () => { | |||
There was a problem hiding this comment.
have vs hasCredentialsChanged?
soberm
approved these changes
May 26, 2025
osama-rizk
approved these changes
May 26, 2025
stocaaro
approved these changes
May 27, 2025
soberm
pushed a commit
that referenced
this pull request
Jun 13, 2025
…#14403) * fix: recreate event buffer in pinpoint if the credentials has changed * fix: update the size limit for the analytics package * chore: address code styling comments --------- Co-authored-by: Aaron S. <94858815+stocaaro@users.noreply.github.com>
Simone319
pushed a commit
that referenced
this pull request
Jun 30, 2025
…#14403) * fix: recreate event buffer in pinpoint if the credentials has changed * fix: update the size limit for the analytics package * chore: address code styling comments --------- Co-authored-by: Aaron S. <94858815+stocaaro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change makes sure that the
getEventBufferfunction of the pinpoint flushes and recreates a new EventBuffer when the credentials are updated.Continuing to use the older credentials were causing to get
403error when events are emitted by Analytics as described in this issue: #14398Issue #14398
Description of how you validated changes
I've validated the changed by linking the updated library to a testing repo and following the reproducing steps provided in the issue.
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.