This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
asynchronous strategy update function, backward compatible #2801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
New feature.
What is the current behavior? (You can also link to an open issue here)
Strategy update function is strictly synchronous.
What is the new behavior (if this is a feature change)?
Now, your strategy's update function can be asynchronous or synchronous. This uses a callback function, as per the convention in this project, and it's backward compatible with synchronous update functions.
Asynchronous update functions should return "true" to indicate that it's operating in asynchronous mode, and call the provided callback when it's done. For example:
update: function (candle, done) {
setTimeout(() => {
// do stuff
done();
});
return true;
}