TheRockTrading support

[paci]

• quick and dirty attempt to add support for therocktrading.com exchange

[askmike]

Great stuff, thanks for the PR. I can test it and might tweak a thing or two, but right now there is one major issue:

Your PR imports the module npm-therocktrading, but I can't find that anywhere on NPM: https://www.npmjs.com/package/npm-therocktrading

Is that on NPM under a different name?

[paci]

I have not published the npm module. But it's available here https://github.com/paci/npm-therocktrading

[askmike]

That code needs to be present for everyone who downloads Gekko and wants to run it on TheRockTrading. As part of the installation process of Gekko, all dependencies such as exchange wrapper libraries are automatically downloaded via NPM, since they are part of this list: https://github.com/askmike/gekko/blob/2e080005eac9f21dd82d34d8c5a76229aef5c146/exchange/package.json#L23-L37 We can add your lib to that list but it needs to be on NPM else the installation will fail. I can publish that library on NPM as well if you don't know how. Regards, Mike

…

On Thu, Apr 25, 2019 at 12:28 PM Davide Barbieri ***@***.***> wrote: I have not published the npm module. But it's available here https://github.com/paci/npm-therocktrading — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2765 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHMYD2RSZTSIPHR77DKK2LPSGBWNANCNFSM4HICTRMA> .

-- PGP key at keybase.io/mikevanrossum <https://keybase.io/mikevanrossum/key.asc>

[paci]

I have published it. Sorry, first time I worked on a node module.

[askmike]

I need to add a few small things to make sure the npm module is installed upon installation. I've created a new PR that includes your work and will be fixing the integration there: #2768

(You will remain author of your additions)