Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

Allow turning on SSL in Docker #2763

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

interfect
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR adds a feature (USE_SSL environment variable to control the Docker entrypoint) and documentation for it.

  • What is the current behavior? (You can also link to an open issue here)

Currently there's no way to tell the docker entrypoint script to use SSL, so the Docker always produces a frontend that wants to talk to a "ws://" endpoint. This doesn't work behind an SSL-terminating reverse proxy.

  • What is the new behavior (if this is a feature change)?

Now you can set USE_SSL=1 along with the HOST and PORT variables, to tell the Docker to serve a frontend that expects to be behind HTTPS.

  • Other information:

@askmike
Copy link
Owner

askmike commented Apr 29, 2019

👍

@askmike askmike merged commit 702b552 into askmike:develop Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants