Skip to content

Expanding Parallel Deployment section of Tomcat Docs#832

Closed
usmazat wants to merge 9 commits into
apache:mainfrom
usmazat:main
Closed

Expanding Parallel Deployment section of Tomcat Docs#832
usmazat wants to merge 9 commits into
apache:mainfrom
usmazat:main

Conversation

@usmazat

@usmazat usmazat commented Mar 19, 2025

Copy link
Copy Markdown

Added a paragraph in the Parallel deployment section of Tomcat docs to include an example of getting current webappVersion via property
Original example was provided by @ChristopherSchultz

usmazat added 2 commits March 18, 2025 16:47
Added an example about geting current webapp version number in a servlet
@markt-asf

Copy link
Copy Markdown
Contributor

If you mention one request attribute you should mention them all. You might need a table.

@usmazat

usmazat commented Mar 20, 2025

Copy link
Copy Markdown
Author

If you mention one request attribute you should mention them all. You might need a table.

I put together a table of attributes. wasn't sure where to put it so I created a separate xml document and put a link in a context.xml

@markt-asf

Copy link
Copy Markdown
Contributor

I like the idea. I don't think we have a list of ServletContext attributes in a single place. The implementation needs a few tweaks to fit in with how we build the Tomcat docs. I'll re-work this using systemprops.xml as a basis.

Also, the list needs to be limited to ServletContext attributes. Other values - such as system properties - are documented elsewhere.

@usmazat

usmazat commented Mar 26, 2025

Copy link
Copy Markdown
Author

I like the idea. I don't think we have a list of ServletContext attributes in a single place. The implementation needs a few tweaks to fit in with how we build the Tomcat docs. I'll re-work this using systemprops.xml as a basis.

Also, the list needs to be limited to ServletContext attributes. Other values - such as system properties - are documented elsewhere.

Thanks @markt-asf , please let me know if there is anything I need to do on my part

markt-asf added a commit that referenced this pull request Mar 26, 2025
markt-asf added a commit that referenced this pull request Mar 26, 2025
markt-asf added a commit that referenced this pull request Mar 26, 2025
markt-asf added a commit that referenced this pull request Mar 26, 2025
@markt-asf

Copy link
Copy Markdown
Contributor

Nothing to do on your part. Thanks for the work you put into this. I've added a new runtime attribute section to the configuration documentation that documents the request and servlet context attributes.

@markt-asf markt-asf closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants