List duplicate locations when failing a deploy due to duplicated fragment names#535
Closed
rolsdorph wants to merge 1 commit into
Closed
List duplicate locations when failing a deploy due to duplicated fragment names#535rolsdorph wants to merge 1 commit into
rolsdorph wants to merge 1 commit into
Conversation
…ment names For complex deployments with many dependencies, it's easy to lose track of exactly which ones are causing trouble. Currently you need to look inside each of your dependency jars in order to figure out what's wrong - I believe this change should be a harmless quality-of-life improvement.
Contributor
|
Thanks for the PR. I like it. I'm probably being over cautious but I'd like to retain backwards compatibility for the existing methods on WebXml - at least up to 10.0.x anyway. Therefore, I'm going to apply this manually with a few tweaks. |
markt-asf
added a commit
that referenced
this pull request
Aug 24, 2022
Now lists the JARs that contain the duplicates. PR by Mads Rolsdorph
markt-asf
added a commit
that referenced
this pull request
Aug 24, 2022
Now lists the JARs that contain the duplicates. PR by Mads Rolsdorph
markt-asf
added a commit
that referenced
this pull request
Aug 24, 2022
Now lists the JARs that contain the duplicates. PR by Mads Rolsdorph
markt-asf
added a commit
that referenced
this pull request
Aug 24, 2022
Now lists the JARs that contain the duplicates. PR by Mads Rolsdorph
Contributor
|
AS per previous comment, merged manually. Thanks very much for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For complex deployments with many dependencies, it's easy to lose track of exactly which ones are causing trouble. Currently, you need to look inside each of your dependency jars in order to figure out what's wrong - I think this change is a harmless quality-of-life improvement, and that it should apply cleanly to all three release branches.