-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6689] Extract kyuubiClientPrincipal/kyuubiClientKeytab/kyuubiServerPrincipal/principal from JDBC connection properties #6693
base: master
Are you sure you want to change the base?
Conversation
59e760c
to
4a1d02e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6693 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 684 687 +3
Lines 42237 42457 +220
Branches 5755 5801 +46
=======================================
- Misses 42237 42457 +220 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
and cc @pan3793 |
Hi @pan3793 , Please review the change |
what about |
My original intention was to pass in the client's authentication information in properties. kyuubiServerPrincipal can be provided by zk and we don't need to get it here. |
this is disabled by default, because the lower Hive client does not support parsing that. It would be weird if |
0f24583
to
7de8d7d
Compare
Hi @pan3793 , I have updated the required. Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
HI @pan3793, Gentle ping |
LGTM, thank you, @Madhukar525722, please update the PR title and desc to match the code |
…ntKeytab/kyuubiServerPrincipal/Principal from JDBC connection properties
HI @pan3793, I have changed as suggested. |
…ab from JDBC connection properties
🔍 Description
Issue References 🔗
This pull request fixes #6689
Describe Your Solution 🔧
It extracts the values of AUTH_KYUUBI_CLIENT_PRINCIPAL, AUTH_KYUUBI_CLIENT_KEYTAB, AUTH_KYUUBI_SERVER_PRINCIPAL and AUTH_PRINCIPAL, then passes it to connParams , to be used for establishing connections.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.