Use return_field instead of return_type for calling aggregates via FFI#17407
Merged
xudong963 merged 4 commits intoSep 7, 2025
Merged
Conversation
45 tasks
comphead
approved these changes
Sep 4, 2025
comphead
left a comment
Contributor
There was a problem hiding this comment.
lgtm thank @timsaucer
WDYT about mentioning the change in upgrading.md ?
Member
Author
I don't think there is any update anyone needs to do unless they have a unit test or something calling |
f6f56bc to
4b0ac9b
Compare
xudong963
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
return_type()instead ofreturn_field()#17400.Rationale for this change
The FFI for aggregate functions was not updated to pass Fields instead of DataType when all of the other Field processing work was done. This corrects that oversight.
What changes are included in this PR?
return_typetoreturn_fieldin aggregate FFI.Are these changes tested?
Yes, additional tests included.
Are there any user-facing changes?
No