Skip to content

Remove .Named() from the ephemeral runner controller#3596

Merged
nikola-jokic merged 1 commit into
masterfrom
nikola-jokic/rename-ctrl
Jun 17, 2024
Merged

Remove .Named() from the ephemeral runner controller#3596
nikola-jokic merged 1 commit into
masterfrom
nikola-jokic/rename-ctrl

Conversation

@nikola-jokic

Copy link
Copy Markdown
Collaborator

Controller metrics would use the controller name as a label. Only the ephemeral runner controller was named, while default names are used for other controllers. This change removes the name change so it is consistent with other controllers

@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Jun 13, 2024
@nikola-jokic nikola-jokic changed the title Remove named from the ephemeral runner controller Remove .Named() from the ephemeral runner controller Jun 13, 2024
@nikola-jokic nikola-jokic merged commit 2cc793a into master Jun 17, 2024
@nikola-jokic nikola-jokic deleted the nikola-jokic/rename-ctrl branch June 17, 2024 08:36
unpollito pushed a commit to DistruApp/actions-runner-controller that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gha-runner-scale-set Related to the gha-runner-scale-set mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants