Delay role/rolebinding creation to gha-runner-scale-set installation time#2363
Conversation
7a35c25 to
fb10c0d
Compare
2eaa39f to
e393667
Compare
fbfc944 to
b54ab93
Compare
e25d041 to
fedc29a
Compare
|
the Check ( |
@TingluoHuang : thanks for your great work! Much appreciated. Any idea on the timeline please? Do you know when this version will become generally available? |
|
This is exactly the change we've been looking for before deploying the controller in our cluster, thank you for your effort. Is it possible to remove the cluster roles entirely? |
@uhthomas #2374 can remove the cluster role, but the trade off is the controller can only create AutoScalingRunnerSet in a single pre-defined namespace. |
Awesome, thank you. This is exactly what we are looking for. We have very strict access controls and intend to run the operator in a single predefined namespace. Is there anything I can do to help get this over the line? |
b54ab93 to
6729502
Compare
1725f23 to
b1d9c03
Compare
926a55e to
c92720f
Compare
b1d9c03 to
8d924ae
Compare
c92720f to
95bd192
Compare
8d924ae to
fb2b6a0
Compare
95bd192 to
86c3186
Compare
fb2b6a0 to
b9c7561
Compare
86c3186 to
d1e4297
Compare
b9c7561 to
2d1e2d2
Compare
rentziass
left a comment
There was a problem hiding this comment.
Left a few nits but looks good to me! ![]()
d1e4297 to
92bb99c
Compare
ca31c3e to
9b97a9f
Compare
92bb99c to
5973a04
Compare
9b97a9f to
0825c8b
Compare
5973a04 to
932d85c
Compare
0825c8b to
1744fe4
Compare
1744fe4 to
d286007
Compare
Part 2 of #2275
ClusterRole/ClusterRoleBindingto manage CRD andList/Watchlow-risk resources.Role/RoleBindingto make sure the manager has permission to create anAutoScalingListenerin the controller installed namespace.Role/RoleBindingto make sure the manager has permission to do everything in the namespace where thegha-runner-scale-setis installed.