Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't display for private repos #6

Closed
leotm opened this issue Aug 15, 2016 · 6 comments
Closed

Doesn't display for private repos #6

leotm opened this issue Aug 15, 2016 · 6 comments

Comments

@leotm
Copy link

leotm commented Aug 15, 2016

Nice little extension!
But unfortunately it doesn't seem to work for private repos.
Would be great if all the deets would be visible to the owner.
Have the feeling Github OAuth would be required in the ext - but well worth it!

@softvar
Copy link
Owner

softvar commented Aug 16, 2016

It does work for me. Can you try again? What didn't work exactly?

Will be rolling out OAuth feature soon. You can try this -https://github.com/softvar/github-plus#github-api-rate-limiting as a workaround for Rate Limiting.

@leotm
Copy link
Author

leotm commented Aug 18, 2016

Turns out this Chrome Ext was causing the download icon not to show 90% of the time:
https://github.com/harshjv/github-repo-size
Great stuff, would be good to be able to run both or even better add ^^ as a new feature.

@softvar softvar mentioned this issue Aug 18, 2016
@softvar
Copy link
Owner

softvar commented Aug 18, 2016

@leotm Hope you're able to see the download icon now.
Will surely add a new feature - to show repo size.

Closing this and opening a new one for the new feature request.

@softvar softvar closed this as completed Aug 18, 2016
@softvar softvar reopened this Aug 20, 2016
@softvar
Copy link
Owner

softvar commented Aug 20, 2016

Hey @leotm ,

I was debugging the issue and found that for it to work for private repos, one has to use Github Access Token.
Follow the guide to use your Github Access Token for authenticated requests and even enjoy lot more requests per minute - https://github.com/softvar/github-plus#github-api-rate-limiting

This will solve the issue.

Thanks for opening this in case someone needs the workaround.

@softvar softvar closed this as completed Aug 20, 2016
@softvar
Copy link
Owner

softvar commented Aug 22, 2016

Hey @leotm,
Now the extension show repo size too and the calls being made are now optimized.

Install the latest v0.1.5 -> https://chrome.google.com/webstore/detail/github-plus/anlikcnbgdeidpacdbdljnabclhahhmd

@leotm
Copy link
Author

leotm commented Aug 23, 2016

Hey @softvar ,
Had to wait/refresh a few times, but can confirm now showing for private repos.
Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants