Skip to content

Conversation

@voxik
Copy link
Contributor

@voxik voxik commented Dec 9, 2024

No description provided.

@radar
Copy link
Collaborator

radar commented Dec 9, 2024

Thank you! Could you please exclude Rails 6.1 + ruby-head from the matrix?

@radar
Copy link
Collaborator

radar commented Dec 9, 2024

@voxik voxik force-pushed the ruby-3.4 branch 2 times, most recently from fa26c6c to b0685b8 Compare December 10, 2024 16:24
These are required for Ruby 3.4 support, which extracts `base64` /
`mutex_m` into bundled gem. The maintained versions of Rails have the
dependencies updated.
@voxik
Copy link
Contributor Author

voxik commented Dec 10, 2024

Thank you! Could you please exclude Rails 6.1 + ruby-head from the matrix?

I have included this patch if you prefer:

diff --git a/gemfiles/Gemfile.rails-6.1.x b/gemfiles/Gemfile.rails-6.1.x
index 6f67f78..43481a6 100644
--- a/gemfiles/Gemfile.rails-6.1.x
+++ b/gemfiles/Gemfile.rails-6.1.x
@@ -8,6 +8,8 @@ gem 'test_declarative', '0.0.6'
 gem 'rake'
 gem 'minitest', '~> 5.14'
 gem 'racc'
+gem 'base64'
+gem 'mutex_m'
 
 platforms :mri do
   gem 'oj'

Rails 8.1 requires Ruby 3.2 at minimum:

~~~
Bundler found conflicting requirements for the Ruby
  In Gemfile.rails-main:
    activesupport was resolved to 8.1.0.alpha, which depends on
      Ruby (>= 3.2.0)
~~~
@voxik
Copy link
Contributor Author

voxik commented Dec 10, 2024

And this combo: https://github.com/ruby-i18n/i18n/actions/runs/12235161164/job/34125870227?pr=709

I'll do that. But it seems the matrix is incomplete. Rails 7.2 / 8.0 should likely be added.

@radar
Copy link
Collaborator

radar commented Dec 10, 2024 via email

@voxik voxik force-pushed the ruby-3.4 branch 3 times, most recently from 7e23f2e to 2399852 Compare December 11, 2024 14:31
@voxik
Copy link
Contributor Author

voxik commented Dec 11, 2024

Agree. Make it so :)

Done.

I have noticed that I18nTest#test_uses_the_simple_backend_by_default test might be flaky. But I'm not going to investigate that.

Also, I'd say that the JRuby might need review.

@radar
Copy link
Collaborator

radar commented Dec 12, 2024

Thank you for your diligence.

@radar radar merged commit 09e26d0 into ruby-i18n:master Dec 12, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants