Return same string object when no interpolations were made

[fatkodima]

See for the details - rails/rails#47421

Even when there are no interpolations, gsub turns SafeBuffer into a String - https://github.com/rails/rails/blob/6af9cba73db6296ab9aec7dbeae1e193ea69f09f/activesupport/lib/active_support/core_ext/string/output_safety.rb#L169
So we need to preserve the original "string" object.

[fatkodima]

Not directly related: But isn't it too costly to allocate a new regexp via Regexp.union(config.interpolation_patterns) each time interpolation is done?

[radar]

Could we store that interpolation regex object so that it’s not recalculated every call? Possibly on the config object itself?

[fatkodima]

That is done on the other PR you just commented.

[radar]

Attempted to resolve the conflicts here after the other PR was merged in to master. Hope I did it right 🤞

[fatkodima]

Resolved conflicts.

[radar]

Thank you!

[jrafanie]

FYI, if you're using gettext_i18n_rails, you'll need to update to 1.10.1+ which plays nicer with this change in i18n 1.13.0.

See also grosser/gettext_i18n_rails#196