Updating DEFAULT_APPROXIMATIONS with capitalised German Eszett character for consistency #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Apologies for the direct ping @radar (lmk whom else I might be able to ping in case) but I saw you recently merged in another PR - is this worth including or should we close? |
Collaborator
|
Sorry @lucapericlp, I must've missed this one back in May somehow. I try to review things within at least two weeks and give feedback then. The change looks good now. Thanks for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uppercase equivalent of the German Eszett was released in a much later version of Unicode and isn't included as part of the first 190 diacritics of unicode between
0xC0&0x17Eso I thought I'd raise this PR in case consistency is desired.