Rewrite node:http to not use Request & Response #14384

Jarred-Sumner · 2024-10-06T13:16:23Z

What does this PR do?

Extremely WIP.

Rewrite node:http to not use Request & Response for Bun.serve

Introduce a new internal API that currently looks like this and may change at any point:

import { serve } from "bun";

serve({
  port: 3002,

  onNodeHTTPRequest(server, url: string, method: string, headers: Record<string, string>, rawHeaders: string[], handle, hasBody: boolean) {
    handle.writeHead(200, { "Content-Type": "text/plain" });
    handle.end("Hello World");
  },
});

This does not replace fetch in Bun.serve()

How did you verify your code works?

it doesn't really work yet. We aren't emitting socket.

robobun · 2024-10-06T13:16:30Z

❌ @cirospaciari, your commit 4bb91a1 has 12 failures in #6736:

test/js/web/fetch/fetch.test.ts - 1 failing on 🍎 aarch64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🐧 x64-baseline

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🪟 x64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🪟 x64-baseline

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🍎 aarch64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🐧 x64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🐧 aarch64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🐧 x64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🐧 aarch64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🐧 x64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🐧 aarch64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🍎 aarch64

test/js/node/test/parallel/http-outgoing-writablefinished.test.js - 1 failing on 🍎 x64

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🪟 x64-baseline

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🪟 x64

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🐧 x64-baseline

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🍎 aarch64

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🐧 aarch64

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🐧 x64

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🐧 aarch64

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🐧 x64

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🍎 aarch64

test/js/node/test/parallel/http-keepalive-request.test.js - timeout on 🍎 x64

test/js/first_party/ws/ws.test.ts - timeout on 🐧 x64-baseline

test/js/first_party/ws/ws.test.ts - timeout on 🪟 x64

test/js/first_party/ws/ws.test.ts - timeout on 🐧 x64-baseline

test/js/first_party/ws/ws.test.ts - timeout on 🍎 aarch64

test/js/first_party/ws/ws.test.ts - timeout on 🪟 x64-baseline

test/js/first_party/ws/ws.test.ts - timeout on 🐧 x64

test/js/first_party/ws/ws.test.ts - timeout on 🐧 aarch64

test/js/first_party/ws/ws.test.ts - timeout on 🐧 x64

test/js/first_party/ws/ws.test.ts - timeout on 🐧 aarch64

test/js/first_party/ws/ws.test.ts - timeout on 🐧 x64

test/js/first_party/ws/ws.test.ts - timeout on 🐧 aarch64

test/js/first_party/ws/ws.test.ts - timeout on 🍎 aarch64

test/js/first_party/ws/ws.test.ts - timeout on 🍎 x64

test/v8/v8.test.ts - 22 failing on 🪟 x64-baseline

test/v8/v8.test.ts - 22 failing on 🪟 x64

test/js/node/http/node-http.test.ts - timeout on 🪟 x64-baseline

test/js/node/http/node-http.test.ts - timeout on 🪟 x64

test/js/node/http/node-http.test.ts - timeout on 🐧 x64-baseline

test/js/node/http/node-http.test.ts - timeout on 🍎 aarch64

test/js/node/http/node-http.test.ts - timeout on 🐧 aarch64

test/js/node/http/node-http.test.ts - timeout on 🐧 x64

test/js/node/http/node-http.test.ts - timeout on 🐧 aarch64

test/js/node/http/node-http.test.ts - timeout on 🐧 x64

test/js/node/http/node-http.test.ts - timeout on 🍎 aarch64

test/js/node/http/node-http.test.ts - timeout on 🍎 x64

test/regression/issue/012040.test.ts - timeout on 🪟 x64-baseline

test/regression/issue/012040.test.ts - timeout on 🪟 x64

test/regression/issue/012040.test.ts - timeout on 🐧 x64-baseline

test/regression/issue/012040.test.ts - timeout on 🐧 aarch64

test/regression/issue/012040.test.ts - timeout on 🐧 x64

test/regression/issue/012040.test.ts - timeout on 🐧 aarch64

test/regression/issue/012040.test.ts - timeout on 🐧 x64

test/regression/issue/012040.test.ts - timeout on 🍎 aarch64

test/regression/issue/012040.test.ts - timeout on 🍎 x64

test/js/node/test/parallel/http-client-timeout.test.js - timeout on 🪟 x64-baseline

test/js/node/test/parallel/http-client-timeout.test.js - timeout on 🪟 x64

test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 x64-baseline

test/js/third_party/pg/pg.test.ts - 1 failing on 🪟 x64-baseline

test/js/third_party/pg/pg.test.ts - 1 failing on 🪟 x64

test/js/third_party/pg/pg.test.ts - 1 failing on 🍎 aarch64

test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 aarch64

test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 x64

test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 aarch64

test/js/third_party/pg/pg.test.ts - 1 failing on 🐧 x64

test/js/third_party/pg/pg.test.ts - 1 failing on 🍎 aarch64

test/js/third_party/pg/pg.test.ts - 1 failing on 🍎 x64

test/js/node/test/parallel/http-upgrade-reconsume-stream.test.js - timeout on 🪟 x64

test/js/node/test/parallel/http-upgrade-reconsume-stream.test.js - timeout on 🪟 x64-baseline

test/js/node/test/parallel/http-upgrade-reconsume-stream.test.js - timeout on 🐧 x64-baseline

test/js/node/test/parallel/http-upgrade-reconsume-stream.test.js - timeout on 🍎 aarch64

test/js/node/test/parallel/http-upgrade-reconsume-stream.test.js - timeout on 🐧 aarch64

test/js/node/test/parallel/http-upgrade-reconsume-stream.test.js - timeout on 🐧 x64

test/js/node/test/parallel/http-upgrade-reconsume-stream.test.js - timeout on 🍎 aarch64

test/js/node/test/parallel/http-upgrade-reconsume-stream.test.js - timeout on 🍎 x64

test/js/node/test/parallel/http-outgoing-finish.test.js - 1 failing on 🪟 x64-baseline

test/js/node/test/parallel/http-outgoing-finish.test.js - 1 failing on 🪟 x64

test/js/node/test/parallel/http-outgoing-finish.test.js - 1 failing on 🐧 x64-baseline

test/js/node/test/parallel/http-outgoing-finish.test.js - 1 failing on 🐧 aarch64

test/js/node/test/parallel/http-outgoing-finish.test.js - 1 failing on 🐧 x64

test/js/node/test/parallel/http-outgoing-finish.test.js - 1 failing on 🐧 aarch64

test/js/node/test/parallel/http-outgoing-finish.test.js - 1 failing on 🐧 x64

test/js/node/test/parallel/http-outgoing-finish.test.js - 1 failing on 🍎 aarch64

test/js/node/test/parallel/http-outgoing-finish.test.js - 1 failing on 🍎 x64

test/js/third_party/pino/pino.test.js - segmentation fault at address 0x1ba499d6980 on 🪟 x64

test/js/third_party/pino/pino.test.js - segmentation fault at address 0xa490 on 🪟 x64-baseline

kravetsone · 2024-10-06T18:51:10Z

will it be available for the first time through the flag? it sounds dangerous if suddenly the insides change so much

Jarred-Sumner · 2024-10-07T05:20:35Z

@kravetsone i agree dangerous, but we have far better test coverage than we used to.

kravetsone · 2024-10-07T08:28:54Z

@kravetsone i agree dangerous, but we have far better test coverage than we used to.

It's great
But it maybe more painful for developers which don't pin bun docker image version

Test coverage can't find all bugs

huseeiin · 2024-10-09T15:20:58Z

super cool

huseeiin · 2024-10-10T12:08:19Z

there was a trick in bun to get the Request object (from a symbol) in node:http:

import { createServer } from "http";

createServer(async (req, res) => {
    const request: Request = req[Object.getOwnPropertySymbols(req)[3]];

    const json = await request.json().catch(() => null);

    res.end(json);
}).listen(3000);

does this PR mean this is no longer gonna be possible?

Rewrite node:http

a660692

okay fastify and express seem to work again

deb44aa

more

68ad269

Update dev-server.test.ts

432e92f

Jarred-Sumner added 3 commits October 7, 2024 06:52

more

7b295c0

tweaks

44f1870

Update http.ts

4a53dee

Jarred-Sumner mentioned this pull request Oct 7, 2024

Bun's Roadmap #159

Open

52 tasks

Jarred-Sumner added 6 commits October 7, 2024 18:46

Automatically stop reading body

1f93522

Fix some of this

d9a1dc7

assign

8ca6dba

Update server.zig

3852109

wip

2de2cb6

Test

da3e716

Jarred-Sumner mentioned this pull request Oct 8, 2024

Memory leak on Nuxt SSR #14389

Open

Merge branch 'main' into jarred/uws

8212e3a

Jarred-Sumner mentioned this pull request Oct 9, 2024

Express post request with transfer-encoding chuncked has no body #8638

Open

stash this

00e017c

Make Next.js 15% faster

9593dcd

Jarred-Sumner added 5 commits October 10, 2024 16:48

Add some more node tests

b7e06a9

Merge branch 'main' into jarred/uws

7afbae8

Fix a couple tests

dae59b6

getting closer

da35833

Fake backpressure

c24ffec

Jarred-Sumner and others added 7 commits October 27, 2024 02:06

Merge branch 'main' into jarred/uws

55ac3af

Add a few tests

8e22382

Create http-incoming-message-destroy.test.js

236b18b

Merge branch 'main' into jarred/uws

6f15bc2

Merge branch 'main' into jarred/uws

5dae742

Merge branch 'main' into jarred/uws

f451262

remove duplicated Tasks tags

0f0ae42

cirospaciari self-assigned this Nov 13, 2024

cirospaciari and others added 22 commits November 13, 2024 17:46

Merge branch 'main' into jarred/uws

7d5a86c

make it compile again

a005a60

Merge branch 'main' into jarred/uws

715ddd8

make it compile again

ca36296

bun run zig-format

00d64e5

Merge branch 'main' into jarred/uws

30653c9

make hspec pass again

a113fba

use net/tls pause resume

a7516d9

pause/resume + deprecated write fix

67f7ff2

opsie

a5bfd35

we should not actually hit this path

352422c

throw in the deprecated behavior

9a8e8df

dont hang if fails

5546c4b

actually encode things

764ec60

lets see

38c32d1

then2

01f2e4c

more fixes + allow test to exit by making sure that the server is closed

29111d4

comments

5a1c82f

wip

4751f6c

WIP upgrade

14a6da6

dont forget the parameter here

5b7b03e

opsie

4bb91a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite node:http to not use Request & Response #14384

Rewrite node:http to not use Request & Response #14384

Jarred-Sumner commented Oct 6, 2024 •

edited

Loading

robobun commented Oct 6, 2024 •

edited

Loading

kravetsone commented Oct 6, 2024

Jarred-Sumner commented Oct 7, 2024

kravetsone commented Oct 7, 2024

huseeiin commented Oct 9, 2024

huseeiin commented Oct 10, 2024

Rewrite node:http to not use Request & Response #14384

Are you sure you want to change the base?

Rewrite node:http to not use Request & Response #14384

Conversation

Jarred-Sumner commented Oct 6, 2024 • edited Loading

What does this PR do?

How did you verify your code works?

robobun commented Oct 6, 2024 • edited Loading

kravetsone commented Oct 6, 2024

Jarred-Sumner commented Oct 7, 2024

kravetsone commented Oct 7, 2024

huseeiin commented Oct 9, 2024

huseeiin commented Oct 10, 2024

Jarred-Sumner commented Oct 6, 2024 •

edited

Loading

robobun commented Oct 6, 2024 •

edited

Loading