Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip counting messages per broadcast #79

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Conversation

rowanseymour
Copy link
Member

And only delete broadcasts that don't have messages

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #79 (908e189) into main (bae126e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   70.78%   70.74%   -0.05%     
==========================================
  Files           6        6              
  Lines         842      834       -8     
==========================================
- Hits          596      590       -6     
+ Misses        141      140       -1     
+ Partials      105      104       -1     
Impacted Files Coverage Δ
archives/messages.go 61.11% <0.00%> (-0.83%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit 1d13ba4 into main Jan 6, 2023
@rowanseymour rowanseymour deleted the bcast_delete_optimzation branch January 6, 2023 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant