Skip to content

Conversation

@officeneerajsaini
Copy link
Contributor

@officeneerajsaini officeneerajsaini commented Feb 11, 2024

Description

This PR migrates the [ABI Stability] guide to the learn section

Validation

Screenshot from 2024-02-11 10-13-35

Screenshot from 2024-02-11 10-14-50

Related Issues

Check List

Fixes #6230

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@officeneerajsaini officeneerajsaini requested a review from a team as a code owner February 11, 2024 04:51
@vercel
Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 10:55am

Copy link
Contributor

@mwenku mwenku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for your first contribution

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Feb 11, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟠 83 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 99 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟠 83 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
85.89% (402/468) 77.16% (125/162) 77.52% (69/89)

Unit Test Report

Tests Skipped Failures Errors Time
72 0 💤 0 ❌ 0 🔥 4.632s ⏱️

@officeneerajsaini
Copy link
Contributor Author

LGTM ! Thanks for your first contribution

I have successfully completed all of my contributions with the assistance of @mwelwankuta
thank you @mwelwankuta ❤️

@mwenku
Copy link
Contributor

mwenku commented Feb 11, 2024

LGTM ! Thanks for your first contribution

I have successfully completed all of my contributions with the assistance of @mwelwankuta thank you @mwelwankuta ❤️

you're welcome, hoping to see more PRs from you

@ovflowd
Copy link
Member

ovflowd commented Feb 12, 2024

There's a missing redirect from the old guide to the new learn section page. (Add an entry on redirects.json) as it was done for other guides.

@paulobelucci
Copy link
Contributor

paulobelucci commented Feb 13, 2024

Hi there! 😃 We have a 404 on the /en/blog/release/v20.6.0 when abi-stability is mentioned.

file: /pages/en/blog/release/v20.6.0.md the link still pointing to guides.

image

@ovflowd
Copy link
Member

ovflowd commented Feb 13, 2024

file: /pages/en/blog/release/v20.6.0.md the link still pointing to guides.

That shouldn't be an issue if we create a redirect from the guide to the learn material on redirects.json

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome contribution ;)

Signed-off-by: Claudio W <[email protected]>
Signed-off-by: Claudio W <[email protected]>
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for your first contribution ✨

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 14, 2024
@ovflowd ovflowd enabled auto-merge February 14, 2024 10:52
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 14, 2024
@ovflowd ovflowd added this pull request to the merge queue Feb 14, 2024
@ovflowd ovflowd removed this pull request from the merge queue due to a manual request Feb 14, 2024
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 14, 2024
@ovflowd ovflowd enabled auto-merge February 14, 2024 10:56
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 14, 2024
@ovflowd ovflowd added this pull request to the merge queue Feb 14, 2024
Merged via the queue into nodejs:main with commit 7f52495 Feb 14, 2024
@officeneerajsaini officeneerajsaini deleted the migrate-abi-stability branch February 14, 2024 11:03
@officeneerajsaini
Copy link
Contributor Author

LGTM! Thank you so much for your first contribution ✨

😊

Copy link
Contributor

@mwenku mwenku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems to be as requested👍

@officeneerajsaini
Copy link
Contributor Author

Subject: Confirmation on Redirect Configuration from Previous Merge PR

Hi @AugustinMauroy ,

I trust this message finds you well. I was going through the details of my previous merge pull request and noticed a redirect configuration in the redirect.json file. Specifically, the source path is currently set as:

"source": "/:locale/guides/abi-stability/"

I wanted to confirm whether the trailing slash at the end of "abi-stability" is intentional or if it might need adjustment. Would it be more appropriate to have the source path without the trailing slash, like this:

"source": "/:locale/guides/abi-stability"

I just want to ensure that the configuration aligns with best practices. Your input on this matter would be highly valuable. Please let me know if there's anything else you need from my end.

@ovflowd
Copy link
Member

ovflowd commented Feb 19, 2024

Subject: Confirmation on Redirect Configuration from Previous Merge PR

Hi @AugustinMauroy ,

I trust this message finds you well. I was going through the details of my previous merge pull request and noticed a redirect configuration in the redirect.json file. Specifically, the source path is currently set as:

"source": "/:locale/guides/abi-stability/"

I wanted to confirm whether the trailing slash at the end of "abi-stability" is intentional or if it might need adjustment. Would it be more appropriate to have the source path without the trailing slash, like this:

"source": "/:locale/guides/abi-stability"

I just want to ensure that the configuration aligns with best practices. Your input on this matter would be highly valuable. Please let me know if there's anything else you need from my end.

No, there shouldn't be trailing slashes.

@officeneerajsaini
Copy link
Contributor Author

Now may some fixed that redirection ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate the legacy guide "ABI Stability" to the learn section

6 participants