-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs(learn): Migrate "ABI Stability" guide to the learn section #6335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mwenku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for your first contribution
|
Lighthouse Results
|
I have successfully completed all of my contributions with the assistance of @mwelwankuta |
you're welcome, hoping to see more PRs from you |
|
There's a missing redirect from the old guide to the new learn section page. (Add an entry on redirects.json) as it was done for other guides. |
That shouldn't be an issue if we create a redirect from the guide to the learn material on |
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome contribution ;)
Signed-off-by: Neeraj Saini <[email protected]>
Signed-off-by: Claudio W <[email protected]>
Signed-off-by: Claudio W <[email protected]>
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you so much for your first contribution ✨
😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change seems to be as requested👍
|
Subject: Confirmation on Redirect Configuration from Previous Merge PR Hi @AugustinMauroy , I trust this message finds you well. I was going through the details of my previous merge pull request and noticed a redirect configuration in the "source": "/:locale/guides/abi-stability/"I wanted to confirm whether the trailing slash at the end of "abi-stability" is intentional or if it might need adjustment. Would it be more appropriate to have the source path without the trailing slash, like this: "source": "/:locale/guides/abi-stability"I just want to ensure that the configuration aligns with best practices. Your input on this matter would be highly valuable. Please let me know if there's anything else you need from my end. |
No, there shouldn't be trailing slashes. |
|
Now may some fixed that redirection .. |

Description
This PR migrates the [ABI Stability] guide to the learn section
Validation
Related Issues
Check List
Fixes #6230
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.