-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
test: remove unnecessary crypto skip #59013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove unnecessary crypto skip #59013
Conversation
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59013 +/- ##
=======================================
Coverage 89.88% 89.89%
=======================================
Files 656 656
Lines 192967 192967
Branches 37848 37856 +8
=======================================
+ Hits 173451 173467 +16
+ Misses 12070 12040 -30
- Partials 7446 7460 +14 🚀 New features to boost your workflow:
|
|
Interestingly the relevant test is now failing on some platforms. But it doesn't seem to have anything to do with crypto, so maybe there is a better skip check. I'll have to review the actual test file now to see why its no longer working. |
|
I'm going to retry CI. Previous run indicated that openssl is required for these tests, but locally I built with |
bbe8966 to
bca32d1
Compare
|
not sure whats up here; going to close for now and maybe revisit another time. |
This crypto check is unnecessary.