Skip to content

Conversation

@Ethan-Arrowood
Copy link
Contributor

This crypto check is unnecessary.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 9, 2025
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.89%. Comparing base (9ec68af) to head (bca32d1).
⚠️ Report is 145 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #59013   +/-   ##
=======================================
  Coverage   89.88%   89.89%           
=======================================
  Files         656      656           
  Lines      192967   192967           
  Branches    37848    37856    +8     
=======================================
+ Hits       173451   173467   +16     
+ Misses      12070    12040   -30     
- Partials     7446     7460   +14     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added the review wanted PRs that need reviews. label Jul 10, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed review wanted PRs that need reviews. labels Jul 12, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Ethan-Arrowood
Copy link
Contributor Author

Interestingly the relevant test is now failing on some platforms. But it doesn't seem to have anything to do with crypto, so maybe there is a better skip check. I'll have to review the actual test file now to see why its no longer working.

@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 18, 2025
@Ethan-Arrowood
Copy link
Contributor Author

I'm going to retry CI.

Previous run indicated that openssl is required for these tests, but locally I built with --without-ssl and the test runs just fine. Maybe I'm missing something obvious. Hopefully a fresh CI run has clearer answers 🤷‍♂️

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 18, 2025
@nodejs-github-bot
Copy link
Collaborator

@Ethan-Arrowood Ethan-Arrowood force-pushed the fix-test-runner-run-files-undefined-test branch from bbe8966 to bca32d1 Compare August 14, 2025 01:40
@nodejs-github-bot
Copy link
Collaborator

@Ethan-Arrowood
Copy link
Contributor Author

not sure whats up here; going to close for now and maybe revisit another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants