Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staff cannot update name reporting when logged out #5031

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

dracos
Copy link
Member

@dracos dracos commented Jun 24, 2024

We have had a few cases where staff forget they are not logged in, report on behalf of someone else when logged out, and have their own account name updated when clicking the confirmation link.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.96%. Comparing base (b595c61) to head (803a2a0).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5031       +/-   ##
===========================================
- Coverage   82.67%   68.96%   -13.71%     
===========================================
  Files         396       42      -354     
  Lines       30821     5098    -25723     
  Branches     4889        0     -4889     
===========================================
- Hits        25481     3516    -21965     
+ Misses       3895     1582     -2313     
+ Partials     1445        0     -1445     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos requested a review from MorayMySoc July 2, 2024 18:05
Copy link
Contributor

@MorayMySoc MorayMySoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dracos dracos force-pushed the staff-name-change-logged-out branch from 35bbd00 to daaccd1 Compare July 3, 2024 12:40
We have had a few cases where staff forget they are not logged in,
report on behalf of someone else when logged out, and have their own
account name updated when clicking the confirmation link.
@dracos dracos force-pushed the staff-name-change-logged-out branch from daaccd1 to 803a2a0 Compare July 3, 2024 12:41
@dracos dracos merged commit 803a2a0 into master Jul 3, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants