Switch to OSM for reverse geocoding

[davea]

No description provided.

[codecov]

Codecov Report

Merging #4444 (46d29f2) into master (fd3f7db) will decrease coverage by 12.68%.
The diff coverage is n/a.

❗ Current head 46d29f2 differs from pull request most recent head ee72137. Consider uploading reports for the commit ee72137 to get more accurate results

@@             Coverage Diff             @@
##           master    #4444       +/-   ##
===========================================
- Coverage   82.27%   69.60%   -12.68%     
===========================================
  Files         364       41      -323     
  Lines       27610     4872    -22738     
  Branches     4276        0     -4276     
===========================================
- Hits        22717     3391    -19326     
+ Misses       3609     1481     -2128     
+ Partials     1284        0     -1284     

see 323 files with indirect coverage changes

[davea]

@dracos not quite finished yet (need to ensure all cobrands' use of resourceSets can handle OSM results) but does this look like the right sort of thing?

[dracos]

Yeah, looking good :)

[dracos]

A few small issues, plus one large issue concerning tests making external calls.

Given the amount of code checking display_name/resourceSets, I'd later suggest we factor that into Problem.pm so it can return one canonical set of data for a geocode row perhaps, would simplify all the changes here, but probably not for now given the issue.

[dracos]

Woo :)