Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Rust): Update my_heap.rs #1309

Merged
merged 1 commit into from
Apr 28, 2024
Merged

fix(Rust): Update my_heap.rs #1309

merged 1 commit into from
Apr 28, 2024

Conversation

rongyi
Copy link
Contributor

@rongyi rongyi commented Apr 28, 2024

First I find here using pop is better than remove, but I'm hesitate to create a PR for this(in case some inconsistent) until I found cpp is using pop_back() too. so here I am :)

@krahets krahets changed the title [Rust] Change remove to pop fix(Rust): Update my_heap.rs Apr 28, 2024
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@krahets krahets added bug Bug fixes code Code-related labels Apr 28, 2024
@krahets krahets merged commit a88c7b9 into krahets:main Apr 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes code Code-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants