[JENKINS-54576] Pipeline baseurlholder should be optional

[mezpahlan]

Makes the baseUrl property in pipeline mode optional. Only applies it if the user explicitly wants to override the default HockeyApp service.

[imod]

@mezpahlan I tested the snapshot with this PR and the following is working now:

        hockeyApp applications: [
                                  [
                                    apiToken: 'XXXX', 
                                    downloadAllowed: true, 
                                    filePath: '**/app-ci.apk', 
                                    mandatory: false, 
                                    notifyTeam: false, 
                                    releaseNotesMethod: none(), 
                                    uploadMethod: 
                                    versionCreation(appId: 'YYYY')
                                  ]
                                ], 
                  debugMode: false, 
                  failGracefully: false
      }

but please be aware, that this did fail:

        hockeyApp applications: [
                                  [
                                    apiToken: 'XXXX', 
                                    downloadAllowed: true, 
                                    filePath: '**/app-beta.apk', 
                                    mandatory: false, 
                                    notifyTeam: false, 
                                    releaseNotesMethod: none(), 
                                    uploadMethod: 
                                    versionCreation(appId: 'YYYY')
                                  ]
                                ], 
                  debugMode: false, 
                  failGracefully: false,
                  baseUrlHolder: [baseUrl: 'https://rink.hockeyapp.net']
      }

error was:

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: 41: Invalid parameter "baseUrlHolder", did you mean "baseUrl"? @ line 41, column 19.
                     baseUrlHolder: [baseUrl: 'https://rink.hockeyapp.net']
                     ^

[mezpahlan]

Thanks @imod that's what I'm expecting. When looking at code that was originally causing an issue it looked like there was a needless object called baseUrlHolder that only held a single string so I removed it in favour of the single baseUrl string.

Yes that will mean existing configurations will break, unfortunately. However this is only an issue if you have explicitly overridden the HockeyApp service and are using the pipeline syntax.

I'll look at preparing some migration text before releasing this fix though. There's already text in the wiki page for this plugin but perhaps it can be made clearer.

Thanks for testing.