[JENKINS-33310] Support setting HOCKEYAPP_INSTALL_URL for Pipelines

[atikhono]

HOCKEYAPP_INSTALL_URL and HOCKEYAPP_CONFIG_URL are not set for Pipelines because the appropriate interface is not implemented. Implement that.

Original PR: #22

In scope of JENKINS-33310

[atikhono]

@reviewbybees

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[atikhono]

@Brantone up

[oleg-nenashev]

lgtm

[douglasknudsen]

This looks awesome! We have been looking forward to this for a bit and had a SO post on it https://stackoverflow.com/questions/45963651/hockeyapp-plugin-and-jenkins-pipeline-and-ha-ockey-app-url

[oleg-nenashev]

ping @Brantone

[douglasknudsen]

Is there maybe another approver available? I'm willing to test and provide input if that helps. The change does look good to me, though I'm not a jenkins plugin whiz, I do recall a Jesse Glick perhaps mentioning that this was the issue in some comments somewhere perhaps.

Also, this addresses https://issues.jenkins-ci.org/browse/JENKINS-37157 as well as 33310

[douglasknudsen]

Tested this the past couple days. I see the availability of HOCKEYAPP_INSTALL_URL__n_ within a pipeline step in the plugin java code. I do NOT see env.HOCKEYAPP_INSTALL_URL__n_ though in the Jenkins arena. 😢 ( using Jenkins 2.111 with all pipeline plugins up-to-date)

[douglasknudsen]

@mezpahlan Perhaps you can have a peek at this? Glad to see some life brought back to this plugin

[mezpahlan]

Hi @douglasknudsen . I was just looking at this as you pinged. Great timing! I'm pretty new to the Jenkins plugin ecosystem and being a maintainer so I do want to take a little time to go over this. My first impressions are yup good enhancement. But I want to familiarise myself a bit more with the functionality (it's not something I use in my own HockeyApp usage). I'm confident we can get this merged quickly, however.

[mezpahlan]

Hi @douglasknudsen sorry for the delay. Yup, looks great and fixes what looks like a real annoyance for people. You mentioned that env.HOCKEYAPP_INSTALL_URL__n_ was not present. Would you say that is gives us cause to look again at this given that the HOCKEYAPP_INSTALL_URL__n_ environment variable was present?

[douglasknudsen]

@mezpahlan I fully understand, I am in similar case without much plugin writing knowledge at all. I can test this though.

Yes, the hockeyplugin variables are not added to the environment variables at all. I can see the plugin log the needed variables to the 'console log' of a build, but they are not available in the environment variables of the pipeline job so we can not say email the hockey build URL at the end of a pipeline based job. I wonder if the base code of this plugin is using too old of a version of Jenkins plugin APIs?? just a stab in the dark. Again, I can test any changes you or @atikhono make.

[mezpahlan]

OK, I think I understand a bit better now. I will see if I can reproduce this on my end and look to a fix. Would the steps to reproduce be something like: Upload to HockeyApp, Receive response from API, print build url to console log, ensure same url is available via the environment variables?

I did bump up the version of Jenkins in the last update so perhaps it is worth trying these changes out with the latest from master.

[douglasknudsen]

Yes, sounds about right. I would expect "sh 'printenv' " in a pipeline after the hockey plugin is complete to surface the hockey properties exposed. This we I can email the direct URL to people that feel important or post it to Slack and such. :)

I tested a direct master pull and build as well as the released version you recently let out, still not showing for me.

[mezpahlan]

That's very useful for me to start having a look at this. I'll try and get some time this weekend to look into how other plugins are doing something similar and see if we can incorporate that approach with our plugin. Thank you again.

[mezpahlan]

Hi @douglasknudsen sorry for the delay. I do see the appropriate environment variables being set when the HockeyApp upload completes and I add sh 'printenv' as the next item in the pipeline.

I tested this against Jenkins 2.121.1 running on Ubuntu 18.04. Here are the environment variables it prints out for me:

HOCKEYAPP_CONFIG_URL_0
HOCKEYAPP_INSTALL_URL
HOCKEYAPP_INSTALL_URL_0
HOCKEYAPP_CONFIG_URL

Given this I am quite tempted to merge this in, what do you think?

[douglasknudsen]

@mezpahlan apologies, on holiday and missed the emails....I can confirm that this change does work for me using Jenkins 2.129. Not sure why it didn't before when I last tested it! likely a cached build or some nonsense. Lets merge it!

[mezpahlan]

No worries, I've been a bit busy too with the World Cup this month. Thank you so much for all your help. Very much appreciated!

[douglasknudsen]

Thanks! and Thanks @atikhono for getting this started!

[jakob-grabner]

Any info when this will be released? Really looking forward to this 😃

[mezpahlan]

@jakob-grabner Apologies this has taken so long. That's my fault. I'll try and get some time this weekend to release it. If I don't please keep pushing me to do so. Apologies again.

[mezpahlan]

@jakob-grabner Released as 1.3.1. Apologies again for the delay.

[jakob-grabner]

Thanks, that's awesome :)

[mezpahlan]

Apologies @douglasknudsen, @jakob-grabner, @atikhono the change in a subsequent commit reverted this change so it isn't released with 1.3.1. I think this was caused by a conflict resolution that I did on #42 .

I'll spin up a branch to fix this and release this tonight.

[douglasknudsen]

ah, gotcha, stuff happens, no worries! Again, just let me know how I can help at any point here. Cheers! Douglas 'DK' Knudsen http://www.cubicleman.com

…

On Tue, Sep 25, 2018 at 1:42 PM Mez Pahlan ***@***.***> wrote: Apologies @douglasknudsen <https://github.com/douglasknudsen>, @jakob-grabner <https://github.com/jakob-grabner>, @atikhono <https://github.com/atikhono> the change in a subsequent commit reverted this change so it isn't released with 1.3.1. I think this was caused by a conflict resolution that I did on #42 <#42> . I'll spin up a branch to fix this and release this tonight. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAK1nE-EmjHZYC9mmdoXKAZwZzYd0K8jks5uemsagaJpZM4RgHCy> .