Skip to content

Conversation

@oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Jan 16, 2018

Work in progress PR...

  • Make the plugin runnable in PCT
  • Add Jenkinsfile
  • Reproduce the issue in PCT and actually fix it IF the reporter provides repro steps. Confirmed, no issue
  • Use Apache HttpComponents Client 4.x API instead of bundled libs

https://issues.jenkins-ci.org/browse/JENKINS-48949

@reviewbybees @jglick

@oleg-nenashev
Copy link
Member Author

After code inspection I was unable to find the issue cause. I suspect that the issue report is incorrect, but I need stacktraces to confirm. This PR can be reviewed and integrated in the current state

@ghost
Copy link

ghost commented Jan 16, 2018

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev oleg-nenashev changed the title [JENKINS-48949] - Make the plugin compatible with Jenkins 2.102+ (JEP-200) [JENKINS-48949] - Make the plugin testable in PCT with JEP-200 Jan 16, 2018
@oleg-nenashev
Copy link
Member Author

@reviewbybees done

@oleg-nenashev
Copy link
Member Author

@Brantone ping

@mezpahlan mezpahlan mentioned this pull request Apr 15, 2018
@mezpahlan mezpahlan merged commit ef08e8a into jenkinsci:master May 27, 2018
@oleg-nenashev
Copy link
Member Author

Thanks a lot @mezpahlan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants