Use WKWebView on macOS #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works for iOS. Trying to get it to work on macOS, but this doesn't work yet. WKWebKit doesn't appear to be available for 32-bit macOS, so remove those builds.
Ultimately this won't work because cacheDisplayInRect doesn't work on WKWebView. Will keep plowing away to make a separate window for the WebView.
This spins up the webview in a separate window. It leaves a blank placeholder inside the player where the webview is positioned. This also allows for devtools to connect to the webview. Right click on the webview and use "Inspect Element".
|
Thank you for this interesting pull-request. About WKScriptMessageHandler, it can coexist with the current code and I would like to merge it. About a separate window, it breaks the current behavior as you noted and it also requires a 64-bit build, so cannot be merged directly. I'll try to make a separate package for 64-bit which contains your modification and a user can choose it if necessary. |
KojiNakamaru
added a commit
that referenced
this pull request
Apr 18, 2017
|
I've imported your code in #162 . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You probably don't want to take this commit, because it has some severe regression in functionality, but I have a problem with the current implementation since I can't connect the Safari debugger.
My main target is iOS and Android. We use the Unity player on macOS. This build "breaks" the webview in the unity player, however, it'll launch the webview in a separate window, and this allows us to right click on the webview and bring up the Safari debugger, which helps a lot during development.